From f3a8efbacf185638cacea0693824d9de894c89b3 Mon Sep 17 00:00:00 2001
From: Ariel Costas Guerrero <ariel@costas.dev>
Date: Wed, 11 Feb 2026 18:18:13 +0100
Subject: refactor: Remove unused logging and streamline stop data handling in
 map and processor components

---
 src/Enmarcha.Backend/Controllers/TileController.cs | 32 +---------------------
 src/Enmarcha.Backend/Services/OtpService.cs        |  2 +-
 .../Processors/VitrasaRealTimeProcessor.cs         |  6 ----
 3 files changed, 2 insertions(+), 38 deletions(-)

(limited to 'src/Enmarcha.Backend')

diff --git a/src/Enmarcha.Backend/Controllers/TileController.cs b/src/Enmarcha.Backend/Controllers/TileController.cs
index 44a2473..856f2c6 100644
--- a/src/Enmarcha.Backend/Controllers/TileController.cs
+++ b/src/Enmarcha.Backend/Controllers/TileController.cs
@@ -5,7 +5,6 @@ using NetTopologySuite.IO.VectorTiles.Mapbox;
 using Microsoft.AspNetCore.Mvc;
 
 using Microsoft.Extensions.Caching.Memory;
-using System.Text.Json;
 using Enmarcha.Sources.OpenTripPlannerGql;
 using Enmarcha.Sources.OpenTripPlannerGql.Queries;
 using Enmarcha.Backend.Configuration;
@@ -126,36 +125,7 @@ public class TileController : ControllerBase
                     { "code", $"{idParts[0]}:{codeWithinFeed}" },
                     { "name", _feedService.NormalizeStopName(feedId, stop.Name) },
                     { "icon", GetIconNameForFeed(feedId) },
-                    { "transitKind", GetTransitKind(feedId) },
-                    // Routes
-                    { "routes", JsonSerializer
-                        .Serialize(
-                            distinctRoutes.Select(r => {
-                            var colour = r.Color ?? Color;
-                            string textColour;
-
-                            if (r.Color is null) // None is present, use fallback
-                            {
-                                textColour = TextColor;
-                            }
-                            else if (r.TextColor is null || r.TextColor.EndsWith("000000"))
-                            {
-                                // Text colour not provided, or default-black; check the better contrasting
-                                textColour = ContrastHelper.GetBestTextColour(colour);
-                            }
-                            else
-                            {
-                                // Use provided text colour
-                                textColour = r.TextColor;
-                            }
-
-                            return new {
-                                shortName = r.ShortName,
-                                colour,
-                                textColour
-                            };
-                        }))
-                    }
+                    { "transitKind", GetTransitKind(feedId) }
                 }
             };
 
diff --git a/src/Enmarcha.Backend/Services/OtpService.cs b/src/Enmarcha.Backend/Services/OtpService.cs
index a01079f..aadff77 100644
--- a/src/Enmarcha.Backend/Services/OtpService.cs
+++ b/src/Enmarcha.Backend/Services/OtpService.cs
@@ -180,7 +180,7 @@ public class OtpService
         var feedId = otpPlace.StopId?.Split(':')[0] ?? "unknown";
         return new PlannerPlace
         {
-            Name = _feedService.NormalizeStopName(feedId, otpPlace.Name),
+            Name = _feedService.NormalizeStopName(feedId, otpPlace.Name!),
             Lat = otpPlace.Lat,
             Lon = otpPlace.Lon,
             StopId = otpPlace.StopId, // Use string directly
diff --git a/src/Enmarcha.Backend/Services/Processors/VitrasaRealTimeProcessor.cs b/src/Enmarcha.Backend/Services/Processors/VitrasaRealTimeProcessor.cs
index d1d1e7d..e374f24 100644
--- a/src/Enmarcha.Backend/Services/Processors/VitrasaRealTimeProcessor.cs
+++ b/src/Enmarcha.Backend/Services/Processors/VitrasaRealTimeProcessor.cs
@@ -134,9 +134,6 @@ public class VitrasaRealTimeProcessor : AbstractRealTimeProcessor
                         scheduledHeadsign = otpArr.Trip.TripHeadsign;
                     }
 
-                    _logger.LogDebug("Matched RT estimate: Line {Line}, RT: {RTRoute} ({RTMin}m), Scheduled: {ScheduledRoute} ({ScheduledMin}m), Delay: {Delay}m",
-                        estimate.Line, estimate.Route, estimate.Minutes, scheduledHeadsign, scheduledMinutes, delayMinutes);
-
                     // Prefer real-time headsign UNLESS it's just the last stop name (which is less informative)
                     if (!string.IsNullOrWhiteSpace(estimate.Route))
                     {
@@ -152,9 +149,6 @@ public class VitrasaRealTimeProcessor : AbstractRealTimeProcessor
                             }
                         }
 
-                        _logger.LogDebug("Headsign: RT='{RT}' vs Scheduled='{Scheduled}', IsJustLastStop={Last}, WillUseRT={Use}",
-                            estimate.Route, scheduledHeadsign, isJustLastStop, !isJustLastStop);
-
                         // Use real-time headsign unless it's just the final stop name
                         if (!isJustLastStop)
                         {
-- 
cgit v1.3