From b2ddc0ef449ccbe7f0d33e539ccdfc1baef04e2c Mon Sep 17 00:00:00 2001 From: Ariel Costas Guerrero Date: Sun, 28 Dec 2025 18:21:17 +0100 Subject: Get favourite stops from OTP instead of pre-generated file --- src/frontend/app/routes/home.tsx | 185 +++++---------------------------------- 1 file changed, 21 insertions(+), 164 deletions(-) (limited to 'src/frontend/app/routes/home.tsx') diff --git a/src/frontend/app/routes/home.tsx b/src/frontend/app/routes/home.tsx index b20a349..3e7f12d 100644 --- a/src/frontend/app/routes/home.tsx +++ b/src/frontend/app/routes/home.tsx @@ -1,4 +1,3 @@ -import Fuse from "fuse.js"; import { History } from "lucide-react"; import { useCallback, useEffect, useMemo, useRef, useState } from "react"; import { useTranslation } from "react-i18next"; @@ -8,7 +7,6 @@ import { usePageTitle } from "~/contexts/PageTitleContext"; import { usePlanner } from "~/hooks/usePlanner"; import StopGallery from "../components/StopGallery"; import StopItem from "../components/StopItem"; -import StopItemSkeleton from "../components/StopItemSkeleton"; import StopDataProvider, { type Stop } from "../data/StopDataProvider"; import "../tailwind-full.css"; @@ -33,15 +31,6 @@ export default function StopList() { [t] ); - const fuse = useMemo( - () => - new Fuse(data || [], { - threshold: 0.3, - keys: ["name", "stopId"], - }), - [data] - ); - const requestUserLocation = useCallback(() => { if (typeof window === "undefined" || !("geolocation" in navigator)) { return; @@ -103,90 +92,33 @@ export default function StopList() { }; }, [requestUserLocation]); - // Sort stops by proximity when we know where the user is located. - const sortedAllStops = useMemo(() => { - if (!data) { - return [] as Stop[]; - } - - if (!userLocation) { - return [...data].sort((a, b) => a.stopId.localeCompare(b.stopId)); - } - - const toRadians = (value: number) => (value * Math.PI) / 180; - const getDistance = ( - lat1: number, - lon1: number, - lat2: number, - lon2: number - ) => { - const R = 6371000; // meters - const dLat = toRadians(lat2 - lat1); - const dLon = toRadians(lon2 - lon1); - const a = - Math.sin(dLat / 2) * Math.sin(dLat / 2) + - Math.cos(toRadians(lat1)) * - Math.cos(toRadians(lat2)) * - Math.sin(dLon / 2) * - Math.sin(dLon / 2); - const c = 2 * Math.atan2(Math.sqrt(a), Math.sqrt(1 - a)); - return R * c; - }; - - return data - .map((stop) => { - if ( - typeof stop.latitude !== "number" || - typeof stop.longitude !== "number" - ) { - return { stop, distance: Number.POSITIVE_INFINITY }; - } - - const distance = getDistance( - userLocation.latitude, - userLocation.longitude, - stop.latitude, - stop.longitude - ); - - return { stop, distance }; - }) - .sort((a, b) => { - if (a.distance === b.distance) { - return a.stop.stopId.localeCompare(b.stop.stopId); - } - return a.distance - b.distance; - }) - .map(({ stop }) => stop); - }, [data, userLocation]); - // Load stops from network const loadStops = useCallback(async () => { try { setLoading(true); - const stops = await StopDataProvider.loadStopsFromNetwork(); - - // Add favourite flags to stops - const favouriteStopsIds = StopDataProvider.getFavouriteIds(); - const stopsWithFavourites = stops.map((stop) => ({ - ...stop, - favourite: favouriteStopsIds.includes(stop.stopId), - })); + const favouriteIds = StopDataProvider.getFavouriteIds(); + const recentIds = StopDataProvider.getRecent(); + const allIds = Array.from(new Set([...favouriteIds, ...recentIds])); - setData(stopsWithFavourites); + const stopsMap = await StopDataProvider.fetchStopsByIds(allIds); - // Update favourite and recent stops with full data - const favStops = stopsWithFavourites.filter((stop) => - favouriteStopsIds.includes(stop.stopId) - ); + const favStops = favouriteIds + .map((id) => stopsMap[id]) + .filter(Boolean) + .map((stop) => ({ ...stop, favourite: true })); setFavouriteStops(favStops); - const recIds = StopDataProvider.getRecent(); - const recStops = recIds - .map((id) => stopsWithFavourites.find((stop) => stop.stopId === id)) - .filter(Boolean) as Stop[]; - setRecentStops(recStops.reverse()); + const recStops = recentIds + .map((id) => stopsMap[id]) + .filter(Boolean) + .map((stop) => ({ + ...stop, + favourite: favouriteIds.includes(stop.stopId), + })); + setRecentStops(recStops); + + setData(Object.values(stopsMap)); } catch (error) { console.error("Failed to load stops:", error); } finally { @@ -205,41 +137,14 @@ export default function StopList() { clearTimeout(searchTimeout.current); } - searchTimeout.current = setTimeout(() => { + searchTimeout.current = setTimeout(async () => { if (searchQuery.length === 0) { setSearchResults(null); return; } - if (!data) { - console.error("No data available for search"); - return; - } - - // Check if search query is a number (stop code search) - const isNumericSearch = /^\d+$/.test(searchQuery.trim()); - - let items: Stop[]; - if (isNumericSearch) { - // Direct match for stop codes - const stopId = searchQuery.trim(); - const exactMatch = data.filter( - (stop) => stop.stopId === stopId || stop.stopId.endsWith(`:${stopId}`) - ); - if (exactMatch.length > 0) { - items = exactMatch; - } else { - // Fuzzy search if no exact match - const results = fuse.search(searchQuery); - items = results.map((result) => result.item); - } - } else { - // Text search using Fuse.js - const results = fuse.search(searchQuery); - items = results.map((result) => result.item); - } - - setSearchResults(items); + // Placeholder for future backend search + setSearchResults([]); }, 300); }; @@ -370,54 +275,6 @@ export default function StopList() { )} {/**/} - - {/* All Stops / Nearby Stops */} -
-
- {userLocation && ( - - - - - )} -

- {userLocation - ? t("stoplist.nearby_stops", "Nearby stops") - : t("stoplist.all_stops", "Paradas")} -

-
- -
    - {loading && ( - <> - {Array.from({ length: 6 }, (_, index) => ( - - ))} - - )} - {!loading && data - ? (userLocation - ? sortedAllStops.slice(0, 6) - : sortedAllStops - ).map((stop) => ) - : null} -
-
)} -- cgit v1.3