Full real-time page, coruña real time

4 files changed, 386 insertions, 5 deletions

diff --git a/src/Costasdev.Busurbano.Backend/Services/Processors/AbstractProcessor.cs b/src/Costasdev.Busurbano.Backend/Services/Processors/AbstractProcessor.cs
new file mode 100644
index 0000000..343f511
--- /dev/null
+++ b/src/Costasdev.Busurbano.Backend/Services/Processors/AbstractProcessor.cs
@@ -0,0 +1,56 @@
+using Costasdev.Busurbano.Backend.Services;
+
+public abstract class AbstractRealTimeProcessor : IArrivalsProcessor
+{
+    public abstract Task ProcessAsync(ArrivalsContext context);
+
+    protected static List<(double Lat, double Lon)> Decode(string encodedPoints)
+    {
+        if (string.IsNullOrEmpty(encodedPoints))
+            return new List<(double, double)>();
+
+        var poly = new List<(double, double)>();
+        char[] polylineChars = encodedPoints.ToCharArray();
+        int index = 0;
+
+        int currentLat = 0;
+        int currentLng = 0;
+        int next5bits;
+        int sum;
+        int shifter;
+
+        while (index < polylineChars.Length)
+        {
+            // calculate next latitude
+            sum = 0;
+            shifter = 0;
+            do
+            {
+                next5bits = (int)polylineChars[index++] - 63;
+                sum |= (next5bits & 31) << shifter;
+                shifter += 5;
+            } while (next5bits >= 32 && index < polylineChars.Length);
+
+            if (index >= polylineChars.Length)
+                break;
+
+            currentLat += (sum & 1) == 1 ? ~(sum >> 1) : (sum >> 1);
+
+            // calculate next longitude
+            sum = 0;
+            shifter = 0;
+            do
+            {
+                next5bits = (int)polylineChars[index++] - 63;
+                sum |= (next5bits & 31) << shifter;
+                shifter += 5;
+            } while (next5bits >= 32 && index < polylineChars.Length);
+
+            currentLng += (sum & 1) == 1 ? ~(sum >> 1) : (sum >> 1);
+
+            poly.Add((Convert.ToDouble(currentLat) / 100000.0, Convert.ToDouble(currentLng) / 100000.0));
+        }
+
+        return poly;
+    }
+}
diff --git a/src/Costasdev.Busurbano.Backend/Services/Processors/CorunaRealTimeProcessor.cs b/src/Costasdev.Busurbano.Backend/Services/Processors/CorunaRealTimeProcessor.cs
new file mode 100644
index 0000000..2ac1554
--- /dev/null
+++ b/src/Costasdev.Busurbano.Backend/Services/Processors/CorunaRealTimeProcessor.cs
@@ -0,0 +1,189 @@
+using Costasdev.Busurbano.Backend.Configuration;
+using Costasdev.Busurbano.Backend.GraphClient.App;
+using Costasdev.Busurbano.Backend.Types;
+using Costasdev.Busurbano.Backend.Types.Arrivals;
+using Costasdev.VigoTransitApi;
+using Costasdev.Busurbano.Sources.TranviasCoruna;
+using Microsoft.Extensions.Options;
+using Arrival = Costasdev.Busurbano.Backend.Types.Arrivals.Arrival;
+
+namespace Costasdev.Busurbano.Backend.Services.Processors;
+
+public class CorunaRealTimeProcessor : AbstractRealTimeProcessor
+{
+    private readonly CorunaRealtimeEstimatesProvider _realtime;
+    private readonly FeedService _feedService;
+    private readonly ILogger<CorunaRealTimeProcessor> _logger;
+    private readonly ShapeTraversalService _shapeService;
+
+    public CorunaRealTimeProcessor(
+        HttpClient http,
+        FeedService feedService,
+        ILogger<CorunaRealTimeProcessor> logger,
+        ShapeTraversalService shapeService)
+    {
+        _realtime = new CorunaRealtimeEstimatesProvider(http);
+        _feedService = feedService;
+        _logger = logger;
+        _shapeService = shapeService;
+    }
+
+    public override async Task ProcessAsync(ArrivalsContext context)
+    {
+        if (!context.StopId.StartsWith("coruna:")) return;
+
+        var normalizedCode = _feedService.NormalizeStopCode("coruna", context.StopCode);
+        if (!int.TryParse(normalizedCode, out var numericStopId)) return;
+
+        try
+        {
+            // Load schedule
+            var todayDate = context.NowLocal.Date.ToString("yyyy-MM-dd");
+
+            Epsg25829? stopLocation = null;
+            if (context.StopLocation != null)
+            {
+                stopLocation = _shapeService.TransformToEpsg25829(context.StopLocation.Latitude, context.StopLocation.Longitude);
+            }
+
+            var realtime = await _realtime.GetEstimatesForStop(numericStopId);
+
+            var usedTripIds = new HashSet<string>();
+            var newArrivals = new List<Arrival>();
+
+            foreach (var estimate in realtime)
+            {
+                var bestMatch = context.Arrivals
+                    .Where(a => !usedTripIds.Contains(a.TripId))
+                    .Where(a => a.Route.RouteIdInGtfs.Trim() == estimate.RouteId.Trim())
+                    .Select(a =>
+                    {
+                        return new
+                        {
+                            Arrival = a,
+                            TimeDiff = estimate.Minutes - a.Estimate.Minutes, // RealTime - Schedule
+                            RouteMatch = true
+                        };
+                    })
+                    .Where(x => x.RouteMatch) // Strict route matching
+                    .Where(x => x.TimeDiff >= -7 && x.TimeDiff <= 75) // Allow 7m early (RealTime < Schedule) or 75m late (RealTime > Schedule)
+                    .OrderBy(x => Math.Abs(x.TimeDiff)) // Best time fit
+                    .FirstOrDefault();
+
+                if (bestMatch == null)
+                {
+                    continue;
+                }
+
+                var arrival = bestMatch.Arrival;
+                _logger.LogInformation("Matched Coruña real-time for line {Line}: {Scheduled}m -> {RealTime}m (diff: {Diff}m)",
+                    arrival.Route.ShortName, arrival.Estimate.Minutes, estimate.Minutes, bestMatch.TimeDiff);
+
+                var scheduledMinutes = arrival.Estimate.Minutes;
+                arrival.Estimate.Minutes = estimate.Minutes;
+                arrival.Estimate.Precision = ArrivalPrecision.Confident;
+
+                // Calculate delay badge
+                var delayMinutes = estimate.Minutes - scheduledMinutes;
+                if (delayMinutes != 0)
+                {
+                    arrival.Delay = new DelayBadge { Minutes = delayMinutes };
+                }
+
+                // Calculate position
+                if (stopLocation != null)
+                {
+                    Position? currentPosition = null;
+                    int? stopShapeIndex = null;
+
+                    if (arrival.RawOtpTrip is ArrivalsAtStopResponse.Arrival otpArrival &&
+                        otpArrival.Trip.Geometry?.Points != null)
+                    {
+                        var decodedPoints = Decode(otpArrival.Trip.Geometry.Points)
+                            .Select(p => new Position { Latitude = p.Lat, Longitude = p.Lon })
+                            .ToList();
+
+                        var shape = _shapeService.CreateShapeFromWgs84(decodedPoints);
+
+                        // Ensure meters is positive
+                        var meters = Math.Max(0, estimate.Metres);
+                        var result = _shapeService.GetBusPosition(shape, stopLocation, meters);
+
+                        currentPosition = result.BusPosition;
+                        stopShapeIndex = result.StopIndex;
+
+                        if (currentPosition != null)
+                        {
+                            _logger.LogInformation("Calculated position from OTP geometry for trip {TripId}: {Lat}, {Lon}", arrival.TripId, currentPosition.Latitude, currentPosition.Longitude);
+                        }
+
+                        // Populate Shape GeoJSON
+                        if (!context.IsReduced && currentPosition != null)
+                        {
+                            var features = new List<object>();
+                            features.Add(new
+                            {
+                                type = "Feature",
+                                geometry = new
+                                {
+                                    type = "LineString",
+                                    coordinates = decodedPoints.Select(p => new[] { p.Longitude, p.Latitude }).ToList()
+                                },
+                                properties = new { type = "route" }
+                            });
+
+                            // Add stops if available
+                            if (otpArrival.Trip.Stoptimes != null)
+                            {
+                                foreach (var stoptime in otpArrival.Trip.Stoptimes)
+                                {
+                                    features.Add(new
+                                    {
+                                        type = "Feature",
+                                        geometry = new
+                                        {
+                                            type = "Point",
+                                            coordinates = new[] { stoptime.Stop.Lon, stoptime.Stop.Lat }
+                                        },
+                                        properties = new
+                                        {
+                                            type = "stop",
+                                            name = stoptime.Stop.Name
+                                        }
+                                    });
+                                }
+                            }
+
+                            arrival.Shape = new
+                            {
+                                type = "FeatureCollection",
+                                features = features
+                            };
+                        }
+                    }
+
+                    if (currentPosition != null)
+                    {
+                        arrival.CurrentPosition = currentPosition;
+                        arrival.StopShapeIndex = stopShapeIndex;
+                    }
+                }
+
+                usedTripIds.Add(arrival.TripId);
+
+            }
+
+            context.Arrivals.AddRange(newArrivals);
+        }
+        catch (Exception ex)
+        {
+            _logger.LogError(ex, "Error fetching Vitrasa real-time data for stop {StopId}", context.StopId);
+        }
+    }
+
+    private static bool IsRouteMatch(string a, string b)
+    {
+        return a == b || a.Contains(b) || b.Contains(a);
+    }
+
+}
diff --git a/src/Costasdev.Busurbano.Backend/Services/Processors/ShapeProcessor.cs b/src/Costasdev.Busurbano.Backend/Services/Processors/ShapeProcessor.cs
index 300ce70..93e4a4f 100644
--- a/src/Costasdev.Busurbano.Backend/Services/Processors/ShapeProcessor.cs
+++ b/src/Costasdev.Busurbano.Backend/Services/Processors/ShapeProcessor.cs
@@ -20,6 +20,9 @@ public class ShapeProcessor : IArrivalsProcessor
 
         foreach (var arrival in context.Arrivals)
         {
+            // If shape is already populated (e.g. by VitrasaRealTimeProcessor), skip
+            if (arrival.Shape != null) continue;
+
             if (arrival.RawOtpTrip is not ArrivalsAtStopResponse.Arrival otpArrival) continue;
 
             var encodedPoints = otpArrival.Trip.Geometry?.Points;
@@ -34,14 +37,46 @@ public class ShapeProcessor : IArrivalsProcessor
                 var points = Decode(encodedPoints);
                 if (points.Count == 0) continue;
 
-                arrival.Shape = new
+                var features = new List<object>();
+
+                // Route LineString
+                features.Add(new
                 {
                     type = "Feature",
                     geometry = new
                     {
                         type = "LineString",
                         coordinates = points.Select(p => new[] { p.Lon, p.Lat }).ToList()
+                    },
+                    properties = new { type = "route" }
+                });
+
+                // Stops
+                if (otpArrival.Trip.Stoptimes != null)
+                {
+                    foreach (var stoptime in otpArrival.Trip.Stoptimes)
+                    {
+                        features.Add(new
+                        {
+                            type = "Feature",
+                            geometry = new
+                            {
+                                type = "Point",
+                                coordinates = new[] { stoptime.Stop.Lon, stoptime.Stop.Lat }
+                            },
+                            properties = new
+                            {
+                                type = "stop",
+                                name = stoptime.Stop.Name
+                            }
+                        });
                     }
+                }
+
+                arrival.Shape = new
+                {
+                    type = "FeatureCollection",
+                    features = features
                 };
             }
             catch (Exception ex)
diff --git a/src/Costasdev.Busurbano.Backend/Services/Processors/VitrasaRealTimeProcessor.cs b/src/Costasdev.Busurbano.Backend/Services/Processors/VitrasaRealTimeProcessor.cs
index 7c98cfb..a16425f 100644
--- a/src/Costasdev.Busurbano.Backend/Services/Processors/VitrasaRealTimeProcessor.cs
+++ b/src/Costasdev.Busurbano.Backend/Services/Processors/VitrasaRealTimeProcessor.cs
@@ -1,23 +1,35 @@
+using Costasdev.Busurbano.Backend.Configuration;
 using Costasdev.Busurbano.Backend.GraphClient.App;
+using Costasdev.Busurbano.Backend.Types;
 using Costasdev.Busurbano.Backend.Types.Arrivals;
 using Costasdev.VigoTransitApi;
+using Microsoft.Extensions.Options;
 
 namespace Costasdev.Busurbano.Backend.Services.Processors;
 
-public class VitrasaRealTimeProcessor : IArrivalsProcessor
+public class VitrasaRealTimeProcessor : AbstractRealTimeProcessor
 {
     private readonly VigoTransitApiClient _api;
     private readonly FeedService _feedService;
     private readonly ILogger<VitrasaRealTimeProcessor> _logger;
+    private readonly ShapeTraversalService _shapeService;
+    private readonly AppConfiguration _configuration;
 
-    public VitrasaRealTimeProcessor(HttpClient http, FeedService feedService, ILogger<VitrasaRealTimeProcessor> logger)
+    public VitrasaRealTimeProcessor(
+        HttpClient http,
+        FeedService feedService,
+        ILogger<VitrasaRealTimeProcessor> logger,
+        ShapeTraversalService shapeService,
+        IOptions<AppConfiguration> options)
     {
         _api = new VigoTransitApiClient(http);
         _feedService = feedService;
         _logger = logger;
+        _shapeService = shapeService;
+        _configuration = options.Value;
     }
 
-    public async Task ProcessAsync(ArrivalsContext context)
+    public override async Task ProcessAsync(ArrivalsContext context)
     {
         if (!context.StopId.StartsWith("vitrasa:")) return;
 
@@ -26,6 +38,15 @@ public class VitrasaRealTimeProcessor : IArrivalsProcessor
 
         try
         {
+            // Load schedule
+            var todayDate = context.NowLocal.Date.ToString("yyyy-MM-dd");
+
+            Epsg25829? stopLocation = null;
+            if (context.StopLocation != null)
+            {
+                stopLocation = _shapeService.TransformToEpsg25829(context.StopLocation.Latitude, context.StopLocation.Longitude);
+            }
+
             var realtime = await _api.GetStopEstimates(numericStopId);
             var estimates = realtime.Estimates
                 .Where(e => !string.IsNullOrWhiteSpace(e.Route) && !e.Route.Trim().EndsWith('*'))
@@ -110,6 +131,85 @@ public class VitrasaRealTimeProcessor : IArrivalsProcessor
                         arrival.Headsign.Destination = estimate.Route;
                     }
 
+                    // Calculate position
+                    if (stopLocation != null)
+                    {
+                        Position? currentPosition = null;
+                        int? stopShapeIndex = null;
+
+                        if (arrival.RawOtpTrip is ArrivalsAtStopResponse.Arrival otpArrival &&
+                            otpArrival.Trip.Geometry?.Points != null)
+                        {
+                            var decodedPoints = Decode(otpArrival.Trip.Geometry.Points)
+                                .Select(p => new Position { Latitude = p.Lat, Longitude = p.Lon })
+                                .ToList();
+
+                            var shape = _shapeService.CreateShapeFromWgs84(decodedPoints);
+
+                            // Ensure meters is positive
+                            var meters = Math.Max(0, estimate.Meters);
+                            var result = _shapeService.GetBusPosition(shape, stopLocation, meters);
+
+                            currentPosition = result.BusPosition;
+                            stopShapeIndex = result.StopIndex;
+
+                            if (currentPosition != null)
+                            {
+                                _logger.LogInformation("Calculated position from OTP geometry for trip {TripId}: {Lat}, {Lon}", arrival.TripId, currentPosition.Latitude, currentPosition.Longitude);
+                            }
+
+                            // Populate Shape GeoJSON
+                            if (!context.IsReduced && currentPosition != null)
+                            {
+                                var features = new List<object>();
+                                features.Add(new
+                                {
+                                    type = "Feature",
+                                    geometry = new
+                                    {
+                                        type = "LineString",
+                                        coordinates = decodedPoints.Select(p => new[] { p.Longitude, p.Latitude }).ToList()
+                                    },
+                                    properties = new { type = "route" }
+                                });
+
+                                // Add stops if available
+                                if (otpArrival.Trip.Stoptimes != null)
+                                {
+                                    foreach (var stoptime in otpArrival.Trip.Stoptimes)
+                                    {
+                                        features.Add(new
+                                        {
+                                            type = "Feature",
+                                            geometry = new
+                                            {
+                                                type = "Point",
+                                                coordinates = new[] { stoptime.Stop.Lon, stoptime.Stop.Lat }
+                                            },
+                                            properties = new
+                                            {
+                                                type = "stop",
+                                                name = stoptime.Stop.Name
+                                            }
+                                        });
+                                    }
+                                }
+
+                                arrival.Shape = new
+                                {
+                                    type = "FeatureCollection",
+                                    features = features
+                                };
+                            }
+                        }
+
+                        if (currentPosition != null)
+                        {
+                            arrival.CurrentPosition = currentPosition;
+                            arrival.StopShapeIndex = stopShapeIndex;
+                        }
+                    }
+
                     usedTripIds.Add(arrival.TripId);
                 }
                 else
@@ -126,9 +226,10 @@ public class VitrasaRealTimeProcessor : IArrivalsProcessor
                         TripId = $"vitrasa:rt:{estimate.Line}:{estimate.Route}:{estimate.Minutes}",
                         Route = new RouteInfo
                         {
+                            GtfsId = $"vitrasa:{estimate.Line}",
                             ShortName = estimate.Line,
                             Colour = template?.Route.Colour ?? "FFFFFF",
-                            TextColour = template?.Route.TextColour ?? "000000"
+                            TextColour = template?.Route.TextColour ?? "000000",
                         },
                         Headsign = new HeadsignInfo
                         {