Properly display arrival low-precision for Vitrasa

6 files changed, 4 insertions, 13 deletions

diff --git a/src/Enmarcha.Backend/Controllers/ArrivalsController.cs b/src/Enmarcha.Backend/Controllers/ArrivalsController.cs
index 16bc047..5c31ed6 100644
--- a/src/Enmarcha.Backend/Controllers/ArrivalsController.cs
+++ b/src/Enmarcha.Backend/Controllers/ArrivalsController.cs
@@ -178,6 +178,8 @@ public partial class ArrivalsController : ControllerBase
             var departureTime = serviceDayLocal.Date.AddSeconds(item.ScheduledDepartureSeconds);
             var minutesToArrive = (int)(departureTime - nowLocal).TotalMinutes;
 
+            var nowInSecondsOfDay = (int)(nowLocal - nowLocal.Date).TotalSeconds;
+
             arrivals.Add(new Arrival
             {
                 TripId = item.Trip.GtfsId,
@@ -192,7 +194,8 @@ public partial class ArrivalsController : ControllerBase
                 Estimate = new ArrivalDetails
                 {
                     Minutes = minutesToArrive,
-                    Precision = departureTime < nowLocal.AddMinutes(-1) ? ArrivalPrecision.Past : ArrivalPrecision.Scheduled
+                    Precision = departureTime < nowLocal.AddMinutes(-1) ? ArrivalPrecision.Past :
+                        nowInSecondsOfDay >= item.Trip.DepartureStoptime.ScheduledDeparture ? ArrivalPrecision.Confident : ArrivalPrecision.Unsure
                 },
                 Operator = feedId == "xunta" ? item.Trip.Route.Agency?.Name : null,
                 RawOtpTrip = item
diff --git a/src/Enmarcha.Backend/Services/Processors/VitrasaRealTimeProcessor.cs b/src/Enmarcha.Backend/Services/Processors/VitrasaRealTimeProcessor.cs
index 3c27e10..43a215b 100644
--- a/src/Enmarcha.Backend/Services/Processors/VitrasaRealTimeProcessor.cs
+++ b/src/Enmarcha.Backend/Services/Processors/VitrasaRealTimeProcessor.cs
@@ -122,7 +122,6 @@ public class VitrasaRealTimeProcessor : AbstractRealTimeProcessor
 
                     var scheduledMinutes = arrival.Estimate.Minutes;
                     arrival.Estimate.Minutes = estimate.Minutes;
-                    arrival.Estimate.Precision = ArrivalPrecision.Confident;
 
                     // Calculate delay badge
                     var delayMinutes = estimate.Minutes - scheduledMinutes;
diff --git a/src/frontend/app/components/arrivals/ArrivalCard.tsx b/src/frontend/app/components/arrivals/ArrivalCard.tsx
index 9c68a97..ec14492 100644
--- a/src/frontend/app/components/arrivals/ArrivalCard.tsx
+++ b/src/frontend/app/components/arrivals/ArrivalCard.tsx
@@ -152,14 +152,6 @@ export const ArrivalCard: React.FC<ArrivalCardProps> = ({
         tone: "warning",
         kind: "warning",
       });
-    } else if (
-      estimate.precision === "confident" &&
-      arrival.currentPosition !== null
-    ) {
-      chips.push({
-        label: t("estimates.bus_gps_position"),
-        kind: "gps",
-      });
     }
 
     if (estimate.precision === "scheduled") {
diff --git a/src/frontend/app/i18n/locales/en-GB.json b/src/frontend/app/i18n/locales/en-GB.json
index 152edb8..c13d96e 100644
--- a/src/frontend/app/i18n/locales/en-GB.json
+++ b/src/frontend/app/i18n/locales/en-GB.json
@@ -74,7 +74,6 @@
     "delay_positive": "{{minutes}} min late",
     "delay_negative": "{{minutes}} min early",
     "previous_trip": "Estimated GPS",
-    "bus_gps_position": "Reliable GPS",
     "low_accuracy": "Low accuracy",
     "no_realtime": "No real-time"
   },
diff --git a/src/frontend/app/i18n/locales/es-ES.json b/src/frontend/app/i18n/locales/es-ES.json
index 364cb5b..cc87ae9 100644
--- a/src/frontend/app/i18n/locales/es-ES.json
+++ b/src/frontend/app/i18n/locales/es-ES.json
@@ -74,7 +74,6 @@
     "delay_positive": "Retraso de {{minutes}} min",
     "delay_negative": "Adelanto de {{minutes}} min",
     "previous_trip": "GPS estimado",
-    "bus_gps_position": "GPS fiable",
     "low_accuracy": "Baja precisión",
     "no_realtime": "Sin tiempo real"
   },
diff --git a/src/frontend/app/i18n/locales/gl-ES.json b/src/frontend/app/i18n/locales/gl-ES.json
index e66f18c..26004c3 100644
--- a/src/frontend/app/i18n/locales/gl-ES.json
+++ b/src/frontend/app/i18n/locales/gl-ES.json
@@ -74,7 +74,6 @@
     "delay_positive": "Atraso de {{minutes}} min",
     "delay_negative": "Adelanto de {{minutes}} min",
     "previous_trip": "GPS estimado",
-    "bus_gps_position": "GPS fiable",
     "low_accuracy": "Baixa precisión",
     "no_realtime": "Sen tempo real"
   },